Open Hub
Open Hub

 Settings |  Report Duplicate

2
I Use This!
Inactive

Commits : Listings

Analyzed about 15 hours ago. based on code collected about 15 hours ago.
Sep 10, 2024 — Sep 10, 2025
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
1. Found a bug in advance_premac... the call to setbc for rho was using the velocity boundary conditions. Changed it to loop over all scalars and properly set bc's. Then I put the multifab_fill_boundary command before the setbc call to cover the corner cells.
ajnonaka
More... about 18 years ago
scalar advance must have a call to multifab_fill_boundary(snew) before each instance of setbc, or else the subsequent call to thermal conduction will fail because it needs valid values of the state variables on the entire domain PLUS the ghost cells in order to compute an edge centered beta. This could be avoided by using a fancy loop in the computation of the solver beta's, but for now this is easier.
ajnonaka
More... about 18 years ago
Fixed a bug in the explicit thermal calculation. I wasn't initializing a multifabl to the proper value.
ajnonaka
More... about 18 years ago
I've commented out steps 4a and 8a -for now- so we can focus on the computation of S using the thermal diffusion terms
ajnonaka
More... about 18 years ago
default is debug true
ajnonaka
More... about 18 years ago
alpha needs one ghost cell.
almgren
More... about 18 years ago
added in the temperature form of the thermal conduction to the "make_explicit_thermal" module. There is a new input flag, default to false, "temperature_diffusion" that determines whether del dot kappa grad T is computed in terms of temperature (true) or enthalpy and species concentrations.
ajnonaka
More... about 18 years ago
compile error fixed. wonder why the compiler didn't complain before I checked in the last version?
ajnonaka
More... about 18 years ago
cleaned up this module quite a bit; it will be much easier to write a Temperature Conduction subroutine now.
ajnonaka
More... about 18 years ago
in the process of adding setbc and fill_boundary calls to the thermal_conduct function. code will compile, but setbc calls are still commented out for now
ajnonaka
More... about 18 years ago
removed debugging print statements
ajnonaka
More... about 18 years ago
bug fix in multifab pointer index
ajnonaka
More... about 18 years ago
first pass at adding species diffusion into "S"
ajnonaka
More... about 18 years ago
bug fix; didn't set h in the ghost cells. h is needed in ghost cells later in the applyop subroutine
ajnonaka
More... about 18 years ago
add a new rule for build_info.f90, so that we are sure that it is regenerated any time we recompile. Previously, the script was not rerun when a file changed, so the build info could be out of date.
mzingale
More... about 18 years ago
to compute beta at hi and lo domains, grab the pressure from the inside cell since p0 has no ghost cells
ajnonaka
More... about 18 years ago
fixed the inflow boundary conditions. enthalpy matches my problem, not small scale. input concentrations are rho*X now
ajnonaka
More... about 18 years ago
making an additional call to multifab_fill_boundary and setbc immediately after initializing the data.
ajnonaka
More... about 18 years ago
removed some debugging print lines.
ajnonaka
More... about 18 years ago
bug fix; beta in operator was coded wrong
ajnonaka
More... about 18 years ago
Added divu as a plotfile variable.
almgren
More... about 18 years ago
first attempt at adding thermal conduction to S. it compiles and runs, let the debugging/testing begin!
ajnonaka
More... about 18 years ago
new module for computing explicit "S"
ajnonaka
More... about 18 years ago
subroutine make_S now takes an additional argument, "thermal" that represents the explicit thermal conduction term (del dot const grad h). The next step is for me to actually compute (del dot const grad h), using a new module I'm going to add, if use_thermal_diffusion .eq. 1
ajnonaka
More... about 18 years ago
turned max_step to 1 and should leave it here until we get the initial projection inconsistency fixed
ajnonaka
More... about 18 years ago
turned off the y-vel offset during the 'read-in data' step. the projection should take care of any offset due to the inflow bc
ajnonaka
More... about 18 years ago
OK, the changes are all in. Try running test_smallscale/inputs_2d_smallscale to see what john and I are seeing... flame propagation that is not smooth and symmetric like the small scale code
ajnonaka
More... about 18 years ago
smaller resolution probelm to run faster
ajnonaka
More... about 18 years ago
There are the inputs I'm now running, with the added:
ajnonaka
More... about 18 years ago
setting initial concentrations to rho X instead of just X in initialization
ajnonaka
More... about 18 years ago