Activity Not Available

Commits : Individual Commit

  Analyzed 3 months ago based on code collected 3 months ago.

Commit ID 97b2ba8046c4cbd46e012300b2c36b325864c728

Anon80 Contributor: Glenn Brown Files Modified: 2
Date: 23-March-2006 at 21:20 Lines Added: 1
Repository: git://git.ipxe.org/mirror/etherboot.git master Lines Removed: 31
Commit Comment: Reviewed by: Marty Conner <md...@etherboot.org>, \ Michael Brown <mbr...@fensystems.co.uk>
[For the record: Michael Brown warns that any driver relying on the
feature added here will not be compatible with gpxe's KEEP_IT_REAL
options, and not be strictly PXE compliant.]

Increase i386 virt_offset alignment to 4kB, so the bottom 12 bits of
corresponding virt and bus addrs will be identical.

This change facilitates porting drivers to Etherboot, as the vast
majority of driver execution environments have this virt/bus alignment
relationship, and non-Etherboot drivers often assume bus addresses are
aligned if the corresponding virtual addrs are aligned.

PCI Express requires DMAs not cross 4kB boundaries, and this large
alignment is required by my forthcoming myri10ge.c 10Gb PCI Express
driver, which is a minimal port of Myricom's Linux driver. Other Linux
driver ports in the future would also surely benefit from this patch.

I have successfully tested this approach with our myri10ge.c driver with
this pathis patch on all 8 PCI express motherboards I have available to
me, representing the following hardware:
CPUs: AMD Opteron and Intel EM64T
Chipsets: Serverworks, Invidia, VIA, Intel, SiS
BIOSes: AMI, Award, IBM, Phoenix AwardBIOS, and Phoenix TrustedCore.

The "HAVE_VIRT_OFFSET" lines of the patch are not strictly necessary,
but are there for clarity and to avoid changing non-i386 behaviour,
since I have no way to test non-i386.

src/arch/i386/include/io.h
==========================

Define HAVE_VIRT_OFFSET.

src/core/relocate.c
===================

On architectures that HAVE_VIRT_OFFSET, align virt_offset on a
4KB boundary.
 

Changes by Language

Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
  C 1 14 0 14 0 3

Changes by File

Showing page 1 of 1
File Language Code Added Code Removed Comments Added Comment Removed Blanks Added Blanks Removed
src/arch/i386/include/io.h C 0 1 0 0 0 0
src/core/relocate.c C 1 13 0 14 0 3