14
I Use This!
Activity Not Available

News

Analyzed 2 months ago. based on code collected over 1 year ago.
Posted over 6 years ago by [email protected]
rme: correctly save playback and output mixer settings. A cut-and-paste oversight at the time the save/restore code was written resulted in the input matrix values being saved for the playback and output matrix mixers as well. Currect this so the ... [More] right matrix mixer will be read when writing the respective parts of the saved configuration. Thanks to Vince who reported the symptoms on ffado-devel and identified the cause. [Less]
Posted over 6 years ago by [email protected]
saffire_dice: allow for trailing space in ConfigROM model name. Under certain conditions, the model name returned by configrom.getModelName() can include trailing spaces. There is a vague recollection that a change in the kernel or libraw1394 at ... [More] some point in the past might give rise to this, but no reference can be immediately tracked down. To address this, simply use the rstrip() method to remove trailing white space. This ensures that the code continues to work with or without the trailing white space. This issue caused ffado-mixer to exit with an error complaining that GlobalMute? was not defined for the Saffire mixer widget. Due to the unexpected white space, the device name never matched any of the expected names and therefore the appropriate UI file (which created the GlobalMute? objects, among many others) was never loaded. Thanks to Dominik Meister for reporting the problem, running further tests to confirm the fundamental cause and suggesting the fix. [Less]
Posted over 6 years ago by [email protected]
Fix compilation of bebob_dl_mgr.cpp. The bebob_dl_mgr.cpp file requires the include of "ffadodevice.h" in order to pick up the definition of ffado_smartptr. Thanks to Jano Svitok for reporting the problem and the solution.
Posted over 6 years ago by [email protected]
PosixMessageQueue?: ensure visibility of SIGEV_THREAD declaration. Orcan Ogetbil reported on the ffado-devel list that during the recent Fedora rebuild effort FFADO 2.3.0 failed to compile because SIGEV_THREAD was undeclared. Jano Svitok made the ... [More] plausible suggestion that signal.h needs to be included explicitly under newer glibc versions. This trivial patch implements this. As of this commit it has not been verified that the problem is fixed with this addition. However, there's no harm done by the change in general and conceptionally the change is consistent with the source file's content given the use of signal-related functionality. [Less]
Posted almost 7 years ago by [email protected]
dbus_util: import DBusQtMainLoop from dbus.mainloop.pyqt5 if dbus.mainloop.qt fails. While "dbus.mainloop.qt" appears to have been present in earlier versions of the PyQt?5 dbus modules for compatibility reasons, it seems it has been removed in ... [More] recent versions. Therefore if use of "dbus.mainloop.qt" fails, try using "dbus.mainloop.pyqt5" instead. This issue was noticed by Xavier Forestier and reported (with the suggested fix) via the ffado-devel mailing list on 6 June 2017. [Less]
Posted almost 7 years ago by [email protected]
ffado-mixer: update manpage with information about the "-b" option. Commit r2670 added the "-b" option to ffado-mixer but the manpage was overlooked. This commit adds documentation about the "-b" option to the ffado-mixer manpage.
Posted almost 7 years ago by [email protected]
mackieonyx: fix mixer module name inconsistency. The name of the python module implementing the Mackie Onyx mixer ("mackie_onyxmixer") was inconsistent with the class name as defined in the "configuration" file ("MackieOnyx?"). The class as ... [More] defined in "mackie_onyxmixer" ("MackieOnyx?") was fine though. To avoid causing unnecessary churn in existing "configuration" files, the mixer module was renamed to "mackieonyx", thus matching what is expected in the "configuration" file definition. This name mismatch was spotted by Xavier Forestier, who implemented a slightly different fix in his November 2016 patch set. [Less]
Posted almost 7 years ago by [email protected]
ffado_mixer: use graphical icon instead of name for mixer pane if available. From Xavier Forestier's November 2016 patchset. In amongst the Qt5 changes was this code to utilise a device-specific graphical image instead of the textual device model ... [More] name in the global mixer pane. The only change from Xavier's patch is the omission of a statement to set the nickname placeholder text to the name of the device. The nickname field is present to support a particular feature of some interfaces, so it shouldn't really be repurposed like this. Otherwise there is a high likelihood of it introducing confusion when used with devices which support the nickname feature. FFADO does not currently ship with any device graphics. Contributions are welcome but care will be needed to ensure that copyrighted images from vendors are not used. The use of official images could give an incorrect impression that ffado-mixer is officially sanctioned by the vendors which is not generally the case. [Less]
Posted almost 7 years ago by [email protected]
ffado-mixer: add device mixers to "View" menu. Xavier Forestier's November 2016 patchset included code which added an entry for each active device's mixer to the "View" menu. For users with a number of different devices this may prove useful. ... [More] This commits Xavier's original patch was with some minor changes to ensure the guid key is resolvable by setTabVisible() under PyQt?4. It has not been tested under PyQt?5. [Less]
Posted almost 7 years ago by [email protected]
ffado_mixer: add a "Themes" submenu to the "View" menu. Xavier Forestier's November 2016 patchset included code to add themes under the "Help" menu which could be selected by the user. The code to do this is relatively simple so there seems ... [More] little reason to hold it back. The only change compared to the submitted patch is to move the themes to a submenu of the "View" menu since conceptually this is a better place than the top of the "Help" menu. [Less]