Open Hub
Black Duck Open Hub

 Settings |  Report Duplicate

22
I Use This!
Inactive

Commits : Listings

Analyzed 17 minutes ago. based on code collected about 3 hours ago.
Apr 25, 2023 — Apr 25, 2024
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
Fixes for gcc's "warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]"
Solar Designer
as solar
More... almost 11 years ago
Wrapped the "header->count > CHARSET_SIZE" check in "#if CHARSET_SIZE < 0xff" to avoid compiler warning on some builds. header->count is an "unsigned char". This change was suggested by magnum (thanks!)
Solar Designer
as solar
More... almost 11 years ago
Moved CHARSET_SIZE from params.h to charset.h since it's not directly user configurable
Solar Designer
as solar
More... almost 11 years ago
Fixed a bug introduced with the "Redefined real_min and real_max to be indices rather than characters" commit. That change turned out to be incomplete, and this fix completes it. Thanks to magnum for reporting the bug and helping bisect the changes.
Solar Designer
as solar
More... almost 11 years ago
When running --fork'ed, only use fsync() on the .pot file, but not on the .rec and .log files (less important and may become unaffordable with large process counts)
Solar Designer
as solar
More... almost 11 years ago
Repeat flock(LOCK_EX) on EINTR
Solar Designer
as solar
More... almost 11 years ago
Fixed the warning: john.c:614:4: warning: format not a string literal and no format arguments [-Wformat-security]
Solar Designer
as solar
More... almost 11 years ago
Close the .rec file before fallback to a non-OpenMP binary
Solar Designer
as solar
More... almost 11 years ago
Call rec_name_complete() from rec_restore_mode() so that the completed filename is shown in possible error messages for the main process (where the original rec_name is temporarily restored by the code in options.c, to make the children re-complete it as appropriate for them)
Solar Designer
as solar
More... almost 11 years ago
Improved the error messages provided when the .rec file is inconsistent with the current configuration rather than is necessarily broken in other ways
Solar Designer
as solar
More... almost 11 years ago
Implemented a second chance for fallback to a non-OpenMP build when the thread count drops to 1 due to --fork (which is only known after parsing of the command-line options and possibly of a .rec file)
Solar Designer
as solar
More... almost 11 years ago
When an OpenMP-enabled build is running against a format lacking OpenMP support and the would-be thread count is greater than 1, suggest the use of --fork with the corresponding number of processes
Solar Designer
as solar
More... almost 11 years ago
Added the "Main process session completed, but some child processes failed" message, to be printed in this special case
Solar Designer
as solar
More... almost 11 years ago
In rec_restore_args(), treat non-existent files in child processes as non-fatal errors. With --restore, terminate the process with zero exit code so that the main process of a restored session where some of the children had previously completed their share of work doesn't unnecessarily keep its .rec file around. With --status, print a message and return to the caller so that status of further nodes may be printed.
Solar Designer
as solar
More... almost 11 years ago
Added "const" to the format argument of log_event()
Solar Designer
as solar
More... almost 11 years ago
Repaired --status of --fork'ed sessions. This was broken when rec_name_complete() was changed not to add the node number into filename used by the main process even for high node numbers. We now temporarily claim that we're not the main process, in order to get rec_name_complete() to behave like it would in a child process, without wasting resources to actually create child processes (not needed for mere status reporting).
Solar Designer
as solar
More... almost 11 years ago
Check the exit status of child processes to decide whether it's OK to remove the .rec file of the main process
Solar Designer
as solar
More... almost 11 years ago
Implemented and made use of rec_done()'s ability to skip the rec_save() call and to close the file, yet not remove the file
Solar Designer
as solar
More... almost 11 years ago
Keep the .rec file opened (and locked) while the main process is waiting for its children to terminate. Close and remove it afterwards, unless the session is interrupted.
Solar Designer
as solar
More... almost 11 years ago
If we're the main process for a --fork'ed group of children, leave our .rec file around until the children terminate
Solar Designer
as solar
More... almost 11 years ago
Exclude sending of signals to child processes in DJGPP builds (untested)
Solar Designer
as solar
More... almost 11 years ago
Removed an overzealous optimization: we must record the entry and length in fix_state() despite of them not changing in inc_key_loop(), because save_state() might be called before the very first call to fix_state() from inc_key_loop() and in that case it must record a previous entry and length.
Solar Designer
as solar
More... almost 11 years ago
Don't bother reporting interrupted wait()
Solar Designer
as solar
More... almost 11 years ago
Corrected the comment on the rationale behind rec_unlock(). The previous analysis was erroneous.
Solar Designer
as solar
More... almost 11 years ago
Corrected --restore of --fork'ed sessions
Solar Designer
as solar
More... almost 11 years ago
Revised the check for when to show OpenMP info to be correct for more than just cracking runs
Solar Designer
as solar
More... almost 11 years ago
Wait for child processes before the main process terminates
Solar Designer
as solar
More... almost 11 years ago
Report OpenMP thread count, after adjusting it for --fork if necessary
Solar Designer
as solar
More... almost 11 years ago
Exclude the portion of code with the fork() call in DJGPP builds (untested)
Solar Designer
as solar
More... almost 11 years ago
With --fork, keep the main process' .rec file without node id in the filename even when it's not the first node (that is, when --node is also specified with a MIN greater than 1).
Solar Designer
as solar
More... almost 11 years ago