Open Hub
Open Hub

 Settings |  Report Duplicate

0
I Use This!
Low Activity

Commits : Listings

Analyzed 1 day ago. based on code collected 1 day ago.
Jul 21, 2024 — Jul 21, 2025
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
Fix for trim to properly skip comparing against the same sequence. Use toTrimIndex == resultIndex && seqs1 == seqs2 instead of toTrimIndex == resultIndex. toTrimIndex == resultIndex was introduced to fix a bug where ruby is doing object comparison instead of equivalency comparisions. What I didn't realize was that result gets written to during the iteration, and we do want to compare if the object has changed. So, try checking both. I'm not 100 percent sure this is the right fix, but it makes a lot of tests pass. Committing for now, and I'll noodle on it tomorrow.
Scott Douglas
More... almost 11 years ago
First pass of getting rid of ComplexSelectorDeque and friends completely in favor of Node. The code runs, but 20ish tests fail. When debugging, I realized we weren't grouping the selectors the same way ruby sass was in extendCompoundSelector, so I implemented group_by_to_a to mimic the same behavior.
Scott Douglas
More... almost 11 years ago
Attempt to replicate the sass 3.2 behavior regarding color formatting.
Matthew Turnbull
More... almost 11 years ago
Use DEBUG_PRINTLN instead of #ifdef
Matthew Turnbull
More... almost 11 years ago
Fix some color names (prefer gray over grey) and fix some typos in the color name hex mappings.
Matthew Turnbull
More... almost 11 years ago
Fixed unification for type selectors. Updated extend unification to always rely on the compound selector unification.
Jamie Addessi
More... almost 11 years ago
Wrapped cerr output in #ifdef DEBUG.
Michael Hellein
More... almost 11 years ago
Removed const to quiet some warnings.
Michael Hellein
More... almost 11 years ago
Fix 216_test_nested_sibling_extend and 217_test_parent_and_sibling_extend. trim was allowing extra duplicate selectors to come through. The main issue was that the ruby code used Array.equal, which was checking if the selectors were the exact same object. This worked because they did a shallow copy of the array, which kept the same objects in both. When porting this, we did a deep comparison of the array, which gave different results. We clone our equivalent of the array, so we can't see if the objects are the same objects. However, we can just keep track of iteration indices and compare them to skip comparing an object against itself.
Scott Douglas
More... almost 11 years ago
SASHIMI-369 - createSelector in node.cpp should remove both the tail and combinator when cloning.
Jamie Addessi
More... almost 11 years ago
Merge branch 'feature/extend-support' of github.com:DealerDotCom/libsass into feature/extend-support
Scott Douglas
More... almost 11 years ago
Fixing sass-spec 010_test_multiple_extends_with_multiple_extenders_and_single_target. We were not properly comparing selectors when putting them into our collection. We relied on Complex_Selector operator less than, but it was simply doing a string comparision. This doesn't treat .a.b the same as .b.a, but we need that behavior since that's closer to what ruby sass does. The fix was to implement operator== for Complex_Selector, Compound_Selector, and Simple_Selector. We compare Complex_Selector and Compound_Selector similarly to how ruby sass does. We still use string comparision for Simple_Selector.
Scott Douglas
More... almost 11 years ago
Merge branch 'feature/extend-support' of https://github.com/DealerDotCom/libsass into feature/extend-support
Jamie Addessi
More... almost 11 years ago
SASHIMI-369 - createSelector in node.cpp should clone only the current compound selector without the tail.
Jamie Addessi
More... almost 11 years ago
Fix makefile for GNU/Darwin
Matthew Turnbull
More... almost 11 years ago
JMA - removed some temporary logging
Jamie Addessi
More... almost 11 years ago
JMA - updated the output ordering for media blocks
Jamie Addessi
More... almost 11 years ago
Merge branch 'feature/extend-support-subweave' into feature/extend-support-subweave-local-osx-10.8.5
Jamie Addessi
More... almost 11 years ago
SASHIMI-374 - Fix media placeholder test cases
Jamie Addessi
More... almost 11 years ago
Fix warning about extra const
Matthew Turnbull
More... almost 11 years ago
Fix signed comparrison warnings
Matthew Turnbull
More... almost 11 years ago
Merge branch 'feature/extend-support-subweave' into feature/extend-support-subweave-local-osx-10.8.5
Jamie Addessi
More... almost 11 years ago
Merge branch 'feature/SASHIMI-375' into feature/extend-support-subweave
Jamie Addessi
More... almost 11 years ago
SASHIMI-375 - Applied fix to output_compressed also. Moved utility function to util.cpp.
Jamie Addessi
More... almost 11 years ago
Merge branch 'feature/SASHIMI-375' into feature/extend-support-subweave
Michael Hellein
More... almost 11 years ago
Check if the pseudo elements are the same in Compound_Selector::is_superselector_of to match ruby sass.
Scott Douglas
More... almost 11 years ago
Merge branch 'feature/SASHIMI-375' into feature/extend-support-subweave-local-osx-10.8.5
Jamie Addessi
More... almost 11 years ago
SASHIMI-375 - Filter out blocks that don't contain any printable statements
Jamie Addessi
More... almost 11 years ago
Removing unused lcs code based on deques now that all the lcs calls use the Node class based lcs functions. Also remove the naive subweave implementation since the real implementation is working pretty well at this point.
Scott Douglas
More... almost 11 years ago
Removing a few more ComplexSelectorOrCombinator functions that the compiler didn't catch since they were wrapped in a DEBUG preprocessor directive.
Scott Douglas
More... almost 11 years ago