237
I Use This!
Very High Activity

Commits : Individual Commit

Analyzed 14 days ago. based on code collected over 2 years ago.

Commit ID b463969044c8d0b434650ff7540026d0011b7fe2

Anon80 Contributor: Todd Lipcon Files Modified 11
Date: 18-April-2018 at 20:51 Lines Added: 398
Repository: git://github.com/apache/kudu.git master Lines Removed: 247
Commit Comment: Modify fix_includes.py for Kudu usage, add a wrapper This makes a few small changes to the upstream fix_includes.py script: - We name our tests 'foo-test.cc' instead of 'foo_test.cc'. Expands the regex appropriately. - Add support for 'IWYU pragma: keep' to avoid removing duplicate headers. Without this, it was attempting to remove the duplicate include in bitshuffle_arch_wrapper.cc which includes the bitshuffle header twice with different #defines - Adds a --blank_line_between_c_and_cxx_includes option which preserves the style that we use. - Adds support for differentiating between thirdparty <foo> includes versus system <foo> includes by checking for file existence in a set of directories passed on the command line. Google apparently uses quoted includes like "protobuf/foo.h" for this purpose whereas we use <>. This also adds a wrapper script build-support/iwyu.py which handles invoking IWYU and also integrating it with the modified fix_includes.py. This takes the place of the old 'iwyu.sh' and associated awk script. It supports automatically piping the IWYU results back through the include fixer and either producing a diff of errors (default output) or fixing them in-situ. Change-Id: I3c286271a39a0d825fb11e5610d8eb7e5b0729b9 Reviewed-on: http://gerrit.cloudera.org:8080/10106 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <ad...@cloudera.com>

Changes by Language

Language Code Added Code Removed Comments Added Comments Removed Blanks Added Blanks Removed
  Python 245 18 84 10 64 1
  CMake 3 1 1 1 0 0
  C++ 1 1 0 0 0 0
  AWK 0 55 0 84 0 4
  shell script 0 37 0 25 0 10

Changes by File

File Language Code Added Code Removed Comments Added Comments Removed Blanks Added Blanks Removed
build-support/build_source_release.py Python 2 4 0 0 0 1
build-support/iwyu/fix_includes.py Python 51 14 44 10 11 0
build-support/iwyu/__init__.py   No source code was detected in this file.
build-support/iwyu/iwyu-filter.awk AWK 0 55 0 84 0 4
build-support/iwyu/iwyu.sh shell script 0 37 0 25 0 10
build-support/iwyu.py Python 188 0 39 0 47 0
build-support/kudu_util.py Python 4 0 1 0 6 0
build-support/release/rat_exclude_files.txt   No source code was detected in this file.
CMakeLists.txt CMake 3 1 1 1 0 0
README.adoc   No source code was detected in this file.