Posted
almost 7 years
ago
by
Philip Armstrong
Xerces C++ rtti requirement.
|
Posted
almost 7 years
ago
by
Philip Armstrong
The change introduced in XERCESC-2088 - Fix undefined casting behavior in DOM means that Xerces now requires rtti to build. Previously Xerces made a point of not requiring rtti and this was one of the reasons we used it.
As requested in the comments Read more
|
Posted
almost 7 years
ago
by
Philip Armstrong
Let’s try again. Apologies for the comment / list spam.
Subject: [PATCH] Change dynamic_casts to virtual methods to avoid the need for
rtti.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This requires
Read more
|
Posted
almost 7 years
ago
by
Philip Armstrong
The patch is included below. I wouldn't claim this is good code style, given the risk of a future programmer creating a class that inherits from DOMNode & one of the sister classes but forgetting to implement the relevant virtual methods, nor is it Read more
|
Posted
almost 7 years
ago
by
Scott Cantor
Bad casting from DOMTextImpl to DOMElementImpl
|
Posted
almost 7 years
ago
by
Roger Leigh
Philip Armstrong It would certainly be useful to see how you implemented this without RTTI. I'm unsure how many Xerces-C++ users rely no no-rtti, is anyone else requiring this?
There are other approaches which could also be considered such as Read more
|
Posted
almost 7 years
ago
by
Philip Armstrong
NB. For our internal use we require no-rtti, so I have written a small patch which replaces the calls to dynamic_cast which virtual methods on DOMNode which return "nullptr" by default & return "this" in those classes which multiply inherit from Read more
|
Posted
almost 7 years
ago
by
Scott Cantor
There's no real connection there, it's just that the site happens to be generated from files that are (unfortunately) a part of the distribution. If you regenerate the site and commit the changed files to the website it doesn't matter if there's a Read more
|
Posted
almost 7 years
ago
by
Roger Leigh
Bad casting from DOMTextImpl to DOMElementImpl
|
Posted
almost 7 years
ago
by
Philip Armstrong
Bad casting from DOMTextImpl to DOMElementImpl
|