Forums : Technical Issue Help

Hi, the analysis of M2R10StdLib seems to have stopped again, the I use this button on the project page has disappeared, too. Further, the source code analysis for M2 is off, it counts negative lines of code, shows the comment average as 0% and for some reason, the M2R10StdLib project no longer shows Very well documented even though the ratio (60%) has not changed. We'd appreciate if somebody can look into this, thanks a lot.

trijezdci almost 14 years ago

Hi trijezdci,

There's a lot going on here.

First, somewhere in our data there are one or more projects with erroneous data analyses, which are resulting in very large negative line totals. This means that the total lines of Modula-2 code on Ohloh is negative, which is clearly incorrect. I have been searching through our data to find these projects and recount the affected projects.

The very well documented flag is applied to a project by comparing its comments to the average number of comments across all Modula-2 code on Ohloh. However, because our site-wide line count totals for Modula-2 are currently negative, we are unable to compute the average comments for Modula-2 projects. This means that for any given project we can't compare the comments to the average, so all of the very well documented flags on Ohloh have disappeared from Modula-2 projects.

I'm not sure what you mean about the I use this button -- it is currently visible for me on the M2R10StdLib project page. Are you still having trouble with this?

I'm continuing to investigate the negative line totals trouble, and it should be resolved within a day or two.

Thanks,
Robin

Robin Luckey almost 14 years ago

Hi Robin,

Yes, the I use this icon is visible again, thanks.

But the commits and statistics don't update, perhaps M2R10StdLib also needs to be recounted?

thanks for looking into this.

trijezdci almost 14 years ago

Our Hg interface is having trouble with revision 199, specifically the file |Examples|/ExampleVector.def.

The pipe (|) characters in the directory name are causing some problems. I think this can be simply fixed with some proper escaping, but it might take a few days to get the fix deployed to our servers.

Robin Luckey almost 14 years ago

Oh dear. I named this directory that way so it would show up last in the list. Do I need to rename it again?

trijezdci almost 14 years ago

Ok, I changed the name of the directory, maybe you want to start the analysis again. thanks.

trijezdci almost 14 years ago

Hi trijezdci,

Renaming the directory does not help at this point, because the previous name still appears in the Hg history log.

I have a patch ready which fixes the problem on our end. It will take a few days before it is deployed to our production servers, at which time I will reschedule the updates.

Thanks,
Robin

Robin Luckey almost 14 years ago

Any news on this issue?

trijezdci almost 14 years ago

I'm interested in seeing some of the stats on this project myself. There's another concern, though, that I've spotted: the code is flagged as well-documented based on other Modula-2 projects?

So if I make a project based on a language that's not in Ohloh yet, and I document 10 lines per one line of code, I'll get told it's only average documentation or something?

ttmrichter almost 14 years ago

We deployed new code with the bug fix to our servers, and the analysis for this project is now complete.

@ttmrichter, yes, comment ratios are compared to the average ratio for all projects written in the same language. So if your project happens to be the only project written in that language, then it by definition contains an average number of comments, and Ohloh will report it that way.

Robin Luckey almost 14 years ago

Thanks Robin, the analysis is working again.

However, the lines of code count for Modula-2 is still negative. Any idea when this is going to be fixed?

trijezdci almost 14 years ago

Hi trijezdci,

The negative line totals for Modula-2 seem to becaused by a single project -- bicycleledpov -- which for some mysterious reason appears to contain -587436 lines of Modula-2.

I'm running a full clean download and re-analysis of that project, and I'm hopeful that this will clean up the mess once and for all. If not, I'll have to do some investigating.

Thanks,
Robin

Robin Luckey almost 14 years ago

I've found the cause of the negative totals.

It appears that the Subversion repository for bicycleledpov is inconsistent in using upper and lower case for directory names. Probably, this code was developed on a Mac, which uses a case insensitive file system by default.

However, our analysis engine is definitely case sensitive, so the result is that our analysis for this project is completely bonkers.

This will not be an easy fix for us at this point. In lieu of a fix, the only solution I can think of is to simply delete the analysis for this project. It's incorrect anyway.

That should clear up the negative line totals for Modula-2 during the nightly refresh. By this time tomorrow the Modula-2 language results should be sane.

Thanks,
Robin

Robin Luckey almost 14 years ago

Hi Robin, thanks for your efforts.

The totals for Modula-2 are now all positive again, but there is still something wrong with the analysis of comments:

The comment ratio for the language is shown as 15% ...

The code analysis for projects M2R10StdLib and M2Regex show comment ratios well above 50% but the projects do not show the well documented property.

The code analysis page for project M2Collections shows a comment ratio of 62% and the project shows the well documented property but the details page behind says the comment ratio is 28%.

However, the code analysis of the GNU Modula-2 project shows a comment ratio of 33%, it is shown as well documented and the comment details page also says 33%, so there is at least one instance where the analysis is correct and consistent.

Could you please look into this, thanks.

trijezdci almost 14 years ago

M2R10StdLib and M2Regex have not been re-analyzed since the recent fixes. Normally, we do no re-analyze a project until a new commit arrives. Since we haven't seen a new commit for these projects, the old analyses are still on display. I will force fresh analyses for these projects.

For M2Collections, I do not see 28% on the details page, I see 62.6%. It is possible that you saw stale cached content, but I'm not sure. Can you give me an URL which shows the incorrect ratio?

Robin Luckey almost 14 years ago

The URL showing 27% comment ratio for M2Collections is:

https://www.ohloh.net/p/m2collections/factoids/2878990

The URL showing 62.6% comment ration for M2Collections is:

https://www.ohloh.net/p/m2collections/analyses/latest

both loaded after clearing browser cache shortly before this post is submitted.

trijezdci almost 14 years ago