Forums : Feedback Forum

Hello,

in Bazaar, it is possible to specify the additional authors of a changeset via the --author="" command line switch. It is also possible to use the switch multiple times, if the changeset has multiple authors.

This is the case of at least one commit in the HelenOS project bzr repository.

Interestingly, ohloh merged the two authors into one contributor - see the HelenOS contributor named Vojtech Horky, Jakub Jermar.

I guess ohloh can be improved to understand that these are actually two contributors rather than one.

Thanks,
Jakub

Jakub Jermar about 13 years ago

This was actually fixed more than 2 years ago, but I guess there was a regression...

Emilien over 12 years ago

Ohloh recently switched to XML log parser for bzr and that log doesn't emit authors. The bug was found and reported a while ago - https://bugs.launchpad.net/bzr-xmloutput/+bug/618307, but has remained unfixed.
I submitted a patch. It would be ideal to have it fixed in xmllog plugin; rather than us patching it locally.
We'll keep you posted.

Abhay Mujumdar over 12 years ago

Great. Does this mean that you have patched your local copy of bzr-xmloutput, or will you wait for the patch to be incorporated? It might take a while for it to appear in a distributed release...

Emilien over 12 years ago

I see that recent commits now seem to be respecting the author field. The old commits where this went wrong still show the commiter, not the author. Would it be possible to correct this?

Example:
http://www.ohloh.net/p/Shaarli/commits

All commits are for author Seb Sauvage (except the "Dummy commit at https://www.ohloh.net/p/Shaarli/commits/145439649 )

Thanks for fixing this though!

Emilien over 12 years ago

Emilien,

I think a re-fetch should help this. I'll start one right away and you will need to check and see if it makes the difference.

Thanks!

ssnow-blackduck over 12 years ago

Emilien,

Re-fetch is finished. Please let me know here one way or the other.

Thanks!

ssnow-blackduck over 12 years ago

Great, thanks for the re-fetch. It solved the issue, at least mostly. I still see one commit [0] where I am listed as the author, while in the Bazaar branch [1] I am the commiter, and Seb Sauvage the author (just like all other commits). Could this be the sign of another bug?

[0] https://www.ohloh.net/p/Shaarli/commits/152229340
[1] http://bazaar.launchpad.net/~emilien-klein/+junk/shaarli/revision/9

Emilien over 12 years ago

Emilien,

We walk the repository from earliest-to-latest and I suspect this is as it is supposed to be. The change made in revision 10 is retroactive to revision 9 and we probably wouldn't see that since we captured revision 9 as it existed at the time it was first committed. I don't know the code involved but I can inquire of someone who does...

Thanks!

ssnow-blackduck over 12 years ago

Emilien,

I think if you note the revision-id in revision you mention (http://bazaar.launchpad.net/~emilien-klein/+junk/shaarli/revision/9) is parsed correctly.

This is the command we use to get bzr log -
bzr log --include-merges --show-id -v --forward

Would it be possible for you let us know which revision here has the author field that we didn't extract correctly?

Abhay Mujumdar over 12 years ago

Abhay,

As you can see in the screenshot below taken from the repo's commit list, r9 has Seb Sauvage as the author, and r10 has me Emilien Klein.

I am the committer of both changesets.

The Ohloh commits page shows me as author of both changesets.

When I run the command you mentionned, I get this output [extract]:

revno: 9
author: Seb Sauvage
committer: Emilien Klein

revno: 10 [merge]
committer: Emilien Klein

So revision 9 is wrongly displayed.

Emilien over 12 years ago